Tibor17 commented on a change in pull request #469:
URL: https://github.com/apache/maven-surefire/pull/469#discussion_r805575480



##########
File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/TestSetRunListener.java
##########
@@ -51,13 +50,13 @@
  * @author Kristian Rosenvold
  */
 public class TestSetRunListener
-    implements RunListener, ConsoleOutputReceiver, ConsoleLogger
+    implements TestRunListener, ConsoleLogger

Review comment:
       Currently, we have to create a new instance of the listener via 
`createReporter()` because the Provider `surefire-junit47` has own instance in 
ThreadLocal. After this has finished in 
[SUREFIRE-1643](https://issues.apache.org/jira/browse/SUREFIRE-1643) and 
[SUREFIRE-1860](https://issues.apache.org/jira/browse/SUREFIRE-1860), we can 
refactor `surefire-junit47` where the ThreadLocal would not be needed and the 
creator of reporter may turn to getter of singleton.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to