[GitHub] [maven] laeubi commented on a change in pull request #675: [MNG-7407] Introduce a ModelVersionProcessor component to make CI Friends Versions pluggable

[GitBox]

laeubi commented on a change in pull request #675:
URL: https://github.com/apache/maven/pull/675#discussion_r805399934



##########
File path: 
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/StringSearchModelInterpolator.java
##########
@@ -68,14 +68,15 @@
     }
 
     @Inject
-    public StringSearchModelInterpolator( PathTranslator pathTranslator, 
UrlNormalizer urlNormalizer )
+    public StringSearchModelInterpolator( PathTranslator pathTranslator, 
UrlNormalizer urlNormalizer,
+                                          ModelVersionProcessor processor )
     {
-        super( pathTranslator, urlNormalizer );
+        super( pathTranslator, urlNormalizer, processor );
     }
 
     StringSearchModelInterpolator()
     {
-        super( null, null );
+        super( null, null, null );

Review comment:
       I think that was for test only but is no longer used, should I remove 
that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org