michael-o commented on a change in pull request #675:
URL: https://github.com/apache/maven/pull/675#discussion_r805389880
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/AbstractStringBasedModelInterpolator.java
##########
@@ -85,13 +79,22 @@
private final PathTranslator pathTranslator;
private final UrlNormalizer urlNormalizer;
+ @Inject
+ private ModelVersionProcessor versionProcessor;
+
@Inject
public AbstractStringBasedModelInterpolator( PathTranslator
pathTranslator, UrlNormalizer urlNormalizer )
{
this.pathTranslator = pathTranslator;
this.urlNormalizer = urlNormalizer;
}
+ public AbstractStringBasedModelInterpolator setVersionPropertiesProcessor(
ModelVersionProcessor processor )
Review comment:
I do not fully understand why this is a setter, but the private field is
injected. Why not inject on directly on the ctor? At the end this is a required
field not optional, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
