MartinKanters commented on pull request #659: URL: https://github.com/apache/maven/pull/659#issuecomment-1038134079
> I see a lot of code has changed due to a conversion from `List` to `Set` (which I think is fine, but I'm not 100% sure) and sometimes a variable rename. Unfortunately, it's all one big commit, which makes it hard for me to focus on the essentials of the change. I understand, it became quite terrible to review, sorry for that. The change in essence is very simple. This is about it: https://github.com/apache/maven/compare/master...MartinKanters:MNG-7390-select-module-outside-pwd-simplified > Is the `List` to `Set` conversion _necessary_ for this feature to work? For the variable rename, I can answer the question myself... ;-) I took the opportunity to refactor the whole class, as I never really liked the coding style much. It's hard to grasp the full business logic and since we have covered it with a lot of unit tests and integration tests I had confidence that I could make the refactor. I've put a list of main things changed in the PR description. If you want, we can have a meeting to go over the points together, let me know. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
