MartinKanters commented on pull request #659: URL: https://github.com/apache/maven/pull/659#issuecomment-1039465240
> > The change in essence is very simple. > > This is about it: [master...MartinKanters:MNG-7390-select-module-outside-pwd-simplified](https://github.com/apache/maven/compare/master...MartinKanters:MNG-7390-select-module-outside-pwd-simplified) > > Thanks, that is very helpful! The essence of the change is indeed pretty simple and I can make sense out of that. > > > [...] since we have covered it with a lot of unit tests and integration tests I had confidence that I could make the refactor > > That's what we have those tests for :-) > > I'm OK with the changes in the "simplified" version. Given that the tests all pass, I'm fine with merging the changes. > > Just a thought: would it be feasible to merge the simplified changes, and then have the refactoring as a separate PR, just to make it easier for everybody to follow along and review? I'd prefer to keep everyone involved as this is a piece of the code which is pretty hard to understand in itself... Sure, that's fine, I can do that. I'll try to split the changes into separate commits for review sake. It will take some time, though, I don't have that much time nowadays.. :) For now I'll create a separate PR for the simplified version (and ensure that the IT branch is renamed to the simplified branch name as well. Then I'll close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
