michael-o commented on a change in pull request #531:
URL: https://github.com/apache/maven/pull/531#discussion_r707069824



##########
File path: 
maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java
##########
@@ -87,22 +92,37 @@
     public PluginVersionResult resolve( PluginVersionRequest request )
         throws PluginVersionResolutionException
     {
+        ConcurrentMap<String, PluginVersionResult> cache = getCache( 
request.getRepositorySession().getData() );
+        String key = getKey( request );

Review comment:
       You don't need the key here, do you? Only when `result` is `null`. I 
would pull it down where it belongs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to