michael-o commented on a change in pull request #531:
URL: https://github.com/apache/maven/pull/531#discussion_r705635537
##########
File path:
maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java
##########
@@ -384,6 +401,36 @@ private PluginVersionResult resolveFromProject(
PluginVersionRequest request, Li
return null;
}
+ @SuppressWarnings( "unchecked" )
+ private Map<String, PluginVersionResult> getCache( SessionData data )
+ {
+ Map<String, PluginVersionResult> cache = ( Map<String,
PluginVersionResult> ) data.get( CACHE_KEY );
+ while ( cache == null )
Review comment:
Why not use `computeIfAbsent?
##########
File path:
maven-core/src/main/java/org/apache/maven/plugin/version/internal/DefaultPluginVersionResolver.java
##########
@@ -384,6 +401,36 @@ private PluginVersionResult resolveFromProject(
PluginVersionRequest request, Li
return null;
}
+ @SuppressWarnings( "unchecked" )
+ private Map<String, PluginVersionResult> getCache( SessionData data )
+ {
+ Map<String, PluginVersionResult> cache = ( Map<String,
PluginVersionResult> ) data.get( CACHE_KEY );
+ while ( cache == null )
Review comment:
Why not use `computeIfAbsent`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
