michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549108800



##########
File path: apache-maven/src/assembly/maven/conf/settings.xml
##########
@@ -244,6 +244,35 @@ under the License.
       </properties>
     </profile>
     -->
+    <profile>
+      <activation>
+        <activeByDefault>true</activeByDefault>

Review comment:
       No, it is not. Colon is invalid for group/artifact ids. For element ids 
nothing is enforced. See: https://issues.apache.org/jira/browse/MNG-7052. I 
intionally did not want to use a period because people might have used 
`maven.repo...`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to