michael-o commented on a change in pull request #419:
URL: https://github.com/apache/maven/pull/419#discussion_r549106196
##########
File path:
maven-core/src/main/java/org/apache/maven/bridge/MavenRepositorySystem.java
##########
@@ -573,15 +573,6 @@ else if ( Artifact.SCOPE_COMPILE.equals( scope ) &&
Artifact.SCOPE_COMPILE.equal
// Code taken from LegacyRepositorySystem
//
- public ArtifactRepository createDefaultRemoteRepository(
MavenExecutionRequest request )
Review comment:
True, I chose to use a highly invasive approach. One could use the same
approach like in the original commits. Retain public method, but return either
`null` or `InvalidRepositoryException`. The contract does not describe any
behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
