rfscholte commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549110820
########## File path: apache-maven/src/assembly/maven/conf/settings.xml ########## @@ -244,6 +244,35 @@ under the License. </properties> </profile> --> + <profile> + <activation> Review comment: version 1.2.0 would be good enough, we're only adding stuff, not breaking things. And we're talking about `config/settings.xml`, not `.m2./settings.xml`. It must be possible to keep the latter at 1.0.0 or 1.1.0, while improving the first one. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org