[ 
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255143#comment-17255143
 ] 

Bertrand Martin commented on DOXIA-616:
---------------------------------------

Do we have a test project with content in md, apt and xdoc formats that are 
supposed to produce the same output? 
I was surprised not to find any integration test, but these are probably in 
maven-site-plugin.

Right now, I'm fighting with the clirr-maven-plugin, which keeps telling me 
that I'm not allowed to remove any class:
{noformat}
[INFO] --- clirr-maven-plugin:2.8:check (default) @ doxia-module-markdown ---
[INFO] Comparing to version: 1.9.1
[ERROR] 8001: 
org.apache.maven.doxia.module.markdown.FlexmarkDoxiaNodeRenderer$Factory: Class 
org.apache.maven.doxia.module.markdown.FlexmarkDoxiaNodeRenderer$Factory removed
{noformat}

I tried specifying to exclude this class in *pom.xml* but it doesn't work...
{code:xml}
  <build>
    <plugins>
      <plugin>
        <groupId>org.codehaus.mojo</groupId>
        <artifactId>clirr-maven-plugin</artifactId>
        <configuration>
          <excludes>
            
<exclude>org/apache/maven/doxia/module/markdown/FlexmarkDoxiaNodeRenderer</exclude>
            
<exclude>org/apache/maven/doxia/module/markdown/FlexmarkDoxiaNodeRenderer/Factory</exclude>
            
<exclude>org/apache/maven/doxia/module/markdown/FlexmarkDoxiaNodeRenderer/*</exclude>
            
<exclude>org/apache/maven/doxia/module/markdown/FlexmarkDoxiaNodeRenderer*</exclude>
            
<exclude>org/apache/maven/doxia/module/markdown/FlexmarkDoxiaNodeRenderer/**</exclude>
            
<exclude>org/apache/maven/doxia/module/markdown/FlexmarkDoxiaNodeRenderer**</exclude>
          </excludes>
        </configuration>
      </plugin>
    </plugins>
  </build>
{code}
Anyway, I'll pursue tomorrow ;-)

> Markdown: Properly expose the language specified in fenced code blocks
> ----------------------------------------------------------------------
>
>                 Key: DOXIA-616
>                 URL: https://issues.apache.org/jira/browse/DOXIA-616
>             Project: Maven Doxia
>          Issue Type: Improvement
>          Components: Module - Markdown
>    Affects Versions: 1.8, 1.9, 1.9.1
>            Reporter: Bertrand Martin
>            Priority: Major
>
> h1. Use Case
> Writers can specify the language used in a fenced code block (typically for 
> syntax highlighting), as in the example below:
> {code}
> ```java
> System.out.println("Beautiful\n");
> ```
> {code}
> Currently, the Doxia module for Markdown does not expose this information 
> ("java") in the produced HTML, so a Maven skin (or frontend renderer) cannot 
> leverage it.
> Produced HTML:
> {code:html}
> <div class="source"> <!-- No mention of Java :-( -->
> <pre>
> System.out.println("Beautiful\n");
> </pre>
> </div>
> {code}
> Wanted result:
> {code:html}
> <div class="source java"> <!-- :-) -->
> <pre>
> System.out.println("Beautiful\n");
> </pre>
> </div>
> {code}
> h1. Specification
> Un-comment this block:
> https://github.com/apache/maven-doxia/blob/c439714e8f4a9e86f9962ac6be9a0077ae9b4d30/doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/FlexmarkDoxiaNodeRenderer.java#L103
> This should do the trick.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to