[GitHub] [maven-surefire] eolivelli commented on a change in pull request #305: enable to flush regularly output of the forked process

[GitBox]

eolivelli commented on a change in pull request #305:
URL: https://github.com/apache/maven-surefire/pull/305#discussion_r451513375



##########
File path: 
surefire-booter/src/main/java/org/apache/maven/surefire/booter/ForkedBooter.java
##########
@@ -129,6 +134,34 @@ private void setupBooter( String tmpDir, String 
dumpFileName, String surefirePro
 
         flushEventChannelOnExit();
 
+        final Long outputFlushInterval = 
providerConfiguration.getOutputFlushInterval();
+        if ( outputFlushInterval != null && outputFlushInterval > 0
+            && LegacyMasterProcessChannelEncoder.class.isInstance( 
eventChannel ) )

Review comment:
       I see.
   The API is still unstable, maybe it is better to change it now.
   I am fine with keeping this trick here as an hotfix.
   but we should create a JIRA at least to not forget




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org