Eskibear commented on pull request #30:
URL: https://github.com/apache/maven-resolver/pull/30#issuecomment-645170247


   @michael-o I just glanced at MRESOLVER-114, and I don't think it's related 
with MRESOLVER-7. 
   Learning for the 
[comments](https://issues.apache.org/jira/browse/MRESOLVER-114?focusedCommentId=17127769&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17127769),
 MRESOLVER-114 is about resolving artifacts in parallel. 
   While here in MRESOLVER-7, the problem is, when the list of dependencies is 
already known, it performs **downloading** of the corresponding pom files in a 
single thread. Given you guys have more context information, correct me if I'm 
wrong. 
   What I see is, networking is the bottleneck. It would be a great performance 
boost even if we just make the downloading parallel. 
   
   
   > Lets start with the first analysis where we will find the parts where the 
downloads can be made parallel.
   
   @Tibor17 Agree with you that we should do some first analysis. Below is what 
I find in master branch, where downloading dependencies is mono-threaded. As 
far as I learn, basic idea of this PR was to make below logic parallel. 
   
https://github.com/apache/maven-resolver/blob/86c1cb28042d2e751ddd657a7490c997cff4cd26/maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java#L347-L351
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to