rfscholte commented on a change in pull request #321: [MNG-5669] same pom.xml
is read multiple times
URL: https://github.com/apache/maven/pull/321#discussion_r371954277
##########
File path:
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
##########
@@ -1352,6 +1449,19 @@ private void importDependencyManagement( Model model,
ModelBuildingRequest reque
return null;
}
+ private <T> T getCache( ModelCache modelCache, Source source,
ModelCacheTag<T> tag )
Review comment:
Somebody else introduced `getCache()` and `putCache()` based on GAV. My
guess: he had to choose between `get()`/`put()` and
`getFromCache()`/`putIntoCache()` and chose a little of both( poldermodel ;) ),
resulting in probably the worst, especially for `getChache()`.
I went for consistency, but since these are private methods we should be
safe to rename them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
