mthmulders commented on a change in pull request #321: [MNG-5669] same pom.xml 
is read multiple times
URL: https://github.com/apache/maven/pull/321#discussion_r371626737
 
 

 ##########
 File path: 
maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelBuilder.java
 ##########
 @@ -1352,6 +1449,19 @@ private void importDependencyManagement( Model model, 
ModelBuildingRequest reque
         return null;
     }
 
+    private <T> T getCache( ModelCache modelCache, Source source, 
ModelCacheTag<T> tag )
 
 Review comment:
   The method name `getCache` suggests that it returns a cache. But one of its 
parameters is _named_ "cache" and it returns a `<T>` instance. Does the name 
`getCache` match with what the method does?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to