[
https://issues.apache.org/jira/browse/MINDEXER-123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16910919#comment-16910919
]
Stephen Buergler commented on MINDEXER-123:
-------------------------------------------
I created a fix here: https://github.com/apache/maven-indexer/pull/38
> Fix an InputStream leak in indexer-reader Utils
> -----------------------------------------------
>
> Key: MINDEXER-123
> URL: https://issues.apache.org/jira/browse/MINDEXER-123
> Project: Maven Indexer
> Issue Type: Bug
> Reporter: Stephen Buergler
> Priority: Trivial
>
> There is a leak of an InputReader in Utils.
> {code:java}
> /**
> * Creates and loads {@link Properties} from provided {@link Resource} if
> exists, and closes the resource. If not
> * exists, returns {@code null}.
> */
> public static Properties loadProperties( final Resource resource )
> throws IOException
> {
> final InputStream inputStream = resource.read();
> if ( inputStream == null )
> {
> return null;
> }
> return loadProperties( resource.read() );
> }
> {code}
> Depending on how the Resource is implemented this probably leaks the
> InputStream returned by the first .read() call. I'm under the understanding
> that .read() should return a new InputStream every time it is called but I
> don't have any evidence that that is true other than that's how the Resource
> in the unit test is implemented.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
