rfscholte commented on a change in pull request #251: [MNG-6665] toolchain.xml
file should support environment variables
URL: https://github.com/apache/maven/pull/251#discussion_r289615423
##########
File path:
maven-core/src/main/java/org/apache/maven/toolchain/building/DefaultToolchainsBuilder.java
##########
@@ -49,7 +56,9 @@
implements ToolchainsBuilder
{
private MavenToolchainMerger toolchainsMerger = new MavenToolchainMerger();
-
+
Review comment:
DefaultToolchainsWriter is annotated with @Component, so it is injectable
here. Please replace new instance creation with @Inject (if
DefaultSettingsBuilder does the same, we'll need to fix it there too)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
