rfscholte commented on a change in pull request #251: [MNG-6665] toolchain.xml
file should support environment variables
URL: https://github.com/apache/maven/pull/251#discussion_r290908623
##########
File path:
maven-core/src/main/java/org/apache/maven/toolchain/building/DefaultToolchainsBuilder.java
##########
@@ -49,7 +56,9 @@
implements ToolchainsBuilder
{
private MavenToolchainMerger toolchainsMerger = new MavenToolchainMerger();
-
+
Review comment:
I like consistency :) And Maven doesn't use classpath scanning at runtime.
There's a descriptor generated at compile time with that kind of information
(to have a shorter warmup at runtime) and I don't think that descriptor
supports constructor injection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
