[ 
https://issues.apache.org/jira/browse/MRESOURCES-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613639#comment-16613639
 ] 

Karl Heinz Marbaise commented on MRESOURCES-237:
------------------------------------------------

There are two..things from my point of view.

# If you have a multi language project this should be handled by the frameworks 
you are using either Java or Javascript. So there should be no need having 
symlinks inside a jar file (which will never work inside the jar file). Apart 
from that who will change the links? The question is why a shell script is 
packaged into a WAR file? Does not make sense from my point of view...
# The behaviour has been changed from 2.X to 3.X which means major version 
change (see [semantical version|https://semver.org/]) which introduced breaking 
changes. 

Furthermore as I mentioned in my previous comment. If you like change this 
behaviour the best would be to offer a pull request with an option which is by 
default {{false}}. cause otherwise it would break backward compatibility within 
the same major version line which will never work.

Apart from that the documentation should be enhanced with this information 
which unfortunately was not the case. 

> Resource plugin's handling of symbolic links changed in 3.0.x, broke existing 
> behavior
> --------------------------------------------------------------------------------------
>
>                 Key: MRESOURCES-237
>                 URL: https://issues.apache.org/jira/browse/MRESOURCES-237
>             Project: Maven Resources Plugin
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 3.0.1, 3.0.2
>         Environment: Apache Maven 3.3.9 
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T11:41:47-05:00)
> Java version: 1.8.0_121, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.121-1.b14.fc25.x86_64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.9.11-200.fc25.x86_64", arch: "amd64", family: 
> "unix"
>            Reporter: Brian D. Johnson
>            Priority: Minor
>
> It looks like the handling of symbolic links in the 
> {{maven-resources-plugin}} has changed in version 3.0.x.  I'm submitting a 
> JIRA because it breaks the previous behavior and I have not been able to find 
> this documented anywhere as an intended change.
> *Use case:* Multi-module maven project.  We have a custom log4j2 
> configuration file we use during testing.  Instead of maintaining this file 
> in multiple {{src/test/resources}} directories, we instead maintain a single 
> copy of the file at the project's root level and create symbolic links from 
> each module's {{src/test/resources}} directory to the file using relative 
> paths.
> *2.7 Behavior:* the symlink was evaluated and the target file was copied to 
> {{target/test-classes/}}.
> *3.0.x Behavior:* the symlink is copied to {{target/test-classes/}} verbatim. 
>  The symlink's relative path results in the symlink pointing to the wrong 
> file location.  The log4j2 configuration is not found.
> *Requested Change:* Either revert to the original 2.7 behavior, or document 
> the change and provide a configuration parameter to allow the legacy behavior.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to