Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/150#discussion_r158589504
  
    --- Diff: 
surefire-providers/surefire-junit4/src/main/java/org/apache/maven/surefire/junit4/JUnit4Provider.java
 ---
    @@ -55,7 +53,8 @@
     import static java.lang.reflect.Modifier.isAbstract;
     import static java.lang.reflect.Modifier.isInterface;
     import static org.apache.maven.surefire.booter.CommandReader.getReader;
    -import static 
org.apache.maven.surefire.common.junit4.JUnit4ProviderUtil.generateFailingTests;
    +import static 
org.apache.maven.surefire.common.junit4.FilterFactory.createMatchDescriptionsFilter;
    --- End diff --
    
    It seems we can move this method to `JUnit4ProviderUtil` and remove 
`org.apache.maven.surefire.common.junit4.FilterFactory`.


---

Reply via email to