[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15080418#comment-15080418
 ] 

Hervé Boutemy commented on DOXIASITETOOLS-134:
----------------------------------------------

why not: clearly documenting this requirement could be sufficient

yes, we need to go forward and the most important is to be clear about it

and if going forward helps people step in, it's a good trade-off: that's why I 
document my findings for years, i.e. let other find their way into this piece 
of code with less efforts than what it cost to me...

So ok for me to do so and clearly document the requirements

> Remove special handling of date format in DefaultSiteRenderer
> -------------------------------------------------------------
>
>                 Key: DOXIASITETOOLS-134
>                 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-134
>             Project: Maven Doxia Sitetools
>          Issue Type: Task
>    Affects Versions: 1.6
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>
> {{dateFormat}} is double-checked from validity and existance in decoration 
> model and set with a fallback when everything fails. We should solely rely on 
> the decoration model because it has a fixed value. This would save code and 
> duplicate fixed values. Every deviation from it is undefined behavior.
> Redudant code for example:
> {code:java}
> DateFormat dateFormat = DateFormat.getDateInstance( DateFormat.DEFAULT, 
> locale );
> PublishDate publishDate = 
> siteRenderingContext.getDecoration().getPublishDate();
> if ( publishDate != null && StringUtils.isNotBlank( publishDate.getFormat() ) 
> )
> {
>     dateFormat = new SimpleDateFormat( publishDate.getFormat(), locale );
> }
> context.put( "dateFormat", dateFormat );
> {code}
> or in {{site.vm}}:
> {code}
>   #if ( $decorationPublishDate && $decorationPublishDate.format )
>     #set ( $format = $decorationPublishDate.format )
>   #else
>     #set ( $format = "yyyy-MM-dd" )
>   #end
> ##
>   $dateFormat.applyPattern( $format )
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to