[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15141462#comment-15141462
]
Hudson commented on DOXIASITETOOLS-134:
---------------------------------------
SUCCESS: Integrated in doxia-all #254 (See
[https://builds.apache.org/job/doxia-all/254/])
[DOXIASITETOOLS-134] Remove special handling of date format in
DefaultSiteRenderer (michaelo:
[http://svn.apache.org/viewvc/?view=rev&rev=1729686])
*
./doxia-sitetools/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java
> Remove special handling of date format in DefaultSiteRenderer
> -------------------------------------------------------------
>
> Key: DOXIASITETOOLS-134
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-134
> Project: Maven Doxia Sitetools
> Issue Type: Task
> Components: Site renderer
> Affects Versions: 1.6
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Fix For: 1.7
>
>
> {{dateFormat}} is double-checked from validity and existance in decoration
> model and set with a fallback when everything fails. We should solely rely on
> the decoration model because it has a fixed value. This would save code and
> duplicate fixed values. Every deviation from it is undefined behavior.
> Redudant code for example:
> {code:java}
> DateFormat dateFormat = DateFormat.getDateInstance( DateFormat.DEFAULT,
> locale );
> PublishDate publishDate =
> siteRenderingContext.getDecoration().getPublishDate();
> if ( publishDate != null && StringUtils.isNotBlank( publishDate.getFormat() )
> )
> {
> dateFormat = new SimpleDateFormat( publishDate.getFormat(), locale );
> }
> context.put( "dateFormat", dateFormat );
> {code}
> or in {{site.vm}}:
> {code}
> #if ( $decorationPublishDate && $decorationPublishDate.format )
> #set ( $format = $decorationPublishDate.format )
> #else
> #set ( $format = "yyyy-MM-dd" )
> #end
> ##
> $dateFormat.applyPattern( $format )
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
