[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15072955#comment-15072955
 ] 

Michael Osipov commented on DOXIASITETOOLS-134:
-----------------------------------------------

No, it is not, DOXIASITETOOLS-101 is about an internal, predictable format for 
technical usage, like metatags etc. The date format in the decoration model is 
for rendering (ihmo ISO makes sense only). Though, I favorize Robert's idea to 
use {{DateTooll}} instead of {{SimpleDateFormat}}.

This issue is about removel of redundant checks for 
{{DecorationModel#getPublishDate()#getFormat()}}. If you look closely at the 
Java code, you'll see that in case of null, a default value is return. This 
means that you don't have to double-check this constantly in Java code und 
Velocity templates.

Hopefully this makes my intention clear.

> Remove special handling of date format in DefaultSiteRenderer
> -------------------------------------------------------------
>
>                 Key: DOXIASITETOOLS-134
>                 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-134
>             Project: Maven Doxia Sitetools
>          Issue Type: Task
>    Affects Versions: 1.6
>            Reporter: Michael Osipov
>
> {{dateFormat}} is double-checked from validity and existance in decoration 
> model and set with a fallback when everything fails. We should solely rely on 
> the decoration model because it has a fixed value. This would save code and 
> duplicate fixed values. Every deviation from it is undefined behavior.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to