rmuir commented on PR #16847: URL: https://github.com/apache/lucene/pull/16847#issuecomment-6268703763
> but maybe it would be less disruptive, at least in terms of files/lines changed, than adding the new `leafMaxDoc`? IMO this would be optimizing for the wrong thing. Giving the user clear compile-time breaks is going to result in more changes on our side, but they should mostly mechanical/easy... aka noise. I knew this would "explode" the PR with such changes when posting the suggestion. I think easy/clear compile-time breakage is many times better than less-type-safe corner-case runtime-breakage (especially if it only happens with large integers above 2B) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
