iverase commented on code in PR #16847:
URL: https://github.com/apache/lucene/pull/16847#discussion_r4311883430
##########
lucene/core/src/java/org/apache/lucene/index/IndexReader.java:
##########
@@ -294,22 +294,25 @@ public final int hashCode() {
*
* <p><b>NOTE</b>: This operation may run in O(maxDoc). Implementations that
can't return this
* number in constant-time should cache it.
+ *
+ * <p>Access the per-segment {@code int} count with {@link
LeafReader#numLeafDocs()}.
*/
- public abstract int numDocs();
+ public abstract long numDocs();
Review Comment:
Do we need to change the methods #docFreq(Term term) and #getDocCount(String
field) to return a long?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
