romseygeek commented on PR #16857: URL: https://github.com/apache/lucene/pull/16857#issuecomment-6219667660
I ran benchmarks for this change and they showed no significant difference. This is mainly about making future changes easier: ``` ┌───────────────────────────────────────────┬─────────────────┬─────────────────┬────────────────────────┬─────────┐ │ Task │ Baseline QPS │ Candidate QPS │ Change │ p-value │ ├───────────────────────────────────────────┼─────────────────┼─────────────────┼────────────────────────┼─────────┤ │ HighTermDayOfYearSort (sort = index sort) │ 741.13 (±38.3%) │ 746.48 (±34.7%) │ +0.7% (−52% to +119%) │ 0.965 │ ├───────────────────────────────────────────┼─────────────────┼─────────────────┼────────────────────────┼─────────┤ │ HighTermMonthSort (sort ≠ index sort) │ 556.61 (±32.9%) │ 636.43 (±39.2%) │ +14.3% (−43% to +129%) │ 0.376 │ ├───────────────────────────────────────────┼─────────────────┼─────────────────┼────────────────────────┼─────────┤ │ PKLookup (control, no sort) │ 297.00 (±37.7%) │ 262.50 (±31.3%) │ −11.6% (−58% to +92%) │ 0.453 │ └───────────────────────────────────────────┴─────────────────┴─────────────────┴────────────────────────┴─────────┘ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
