rmuir commented on PR #16788: URL: https://github.com/apache/lucene/pull/16788#issuecomment-6039406055
in general, i really dislike exceptions such as CorruptIndexException/CorruptSegmentInfoException. it seems to have gotten quite bad here as we have corruptindexexceptions being now boxed into corruptsegmenfinfoexception (!) it seems to put us in the impossible place of determining whether an error is a "corruption" or not. but we don't really know. often times the error is just from the operating system and might mean a number of things. I understand apps would rather not deal with this, and want the library to solve it for them... I think thats how we got here, but we're really not positioned to do it. actually the app has better context on how to deal with a specific exception since its presumably doing more than just using the library. for example, maybe it is using replication or other error-tolerant features. I think if we hit e.g. EOFException, we should deliver the EOFException faithfully, and let the caller decide what to do... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
