kaivalnp commented on code in PR #16506:
URL: https://github.com/apache/lucene/pull/16506#discussion_r3846207794
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/codecs/dedup/DedupFlatVectorsScorer.java:
##########
@@ -37,112 +36,123 @@
*
* @lucene.experimental
*/
-final class DedupFlatVectorsScorer implements FlatVectorsScorer {
- private static final FlatVectorsScorer SCORER =
+sealed class DedupFlatVectorsScorer implements FlatVectorsScorer
+ permits DedupScalarQuantizedVectorsScorer {
+
+ private static final FlatVectorsScorer FLAT_SCORER =
FlatVectorScorerUtil.getLucene99FlatVectorsScorer();
+ private final FlatVectorsScorer scorer;
Review Comment:
Makes sense, changed to `delegate`!
##########
lucene/sandbox/src/java/org/apache/lucene/sandbox/codecs/dedup/DedupFlatVectorsScorer.java:
##########
@@ -37,112 +36,123 @@
*
* @lucene.experimental
*/
-final class DedupFlatVectorsScorer implements FlatVectorsScorer {
- private static final FlatVectorsScorer SCORER =
+sealed class DedupFlatVectorsScorer implements FlatVectorsScorer
+ permits DedupScalarQuantizedVectorsScorer {
+
+ private static final FlatVectorsScorer FLAT_SCORER =
FlatVectorScorerUtil.getLucene99FlatVectorsScorer();
+ private final FlatVectorsScorer scorer;
+
+ DedupFlatVectorsScorer() {
+ this(FLAT_SCORER);
+ }
+
+ protected DedupFlatVectorsScorer(FlatVectorsScorer scorer) {
+ this.scorer = scorer;
+ }
+
+ /** Resolves the values to score; subclasses may unwrap composite values. */
Review Comment:
Makes sense, changed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
