costin commented on PR #16283:
URL: https://github.com/apache/lucene/pull/16283#issuecomment-4798596288
> Have few minor comments. Also I think we should unit tests which cover
scenarios with different cardinality values where it is > 1, vectorLen %
cardinality != 0 and other cases? Assuming this is not already covered via
existing tests.
See my other comments. I've parameterized
testSortedNumericRangeIntoBitSetVaryingCardinality to exercise the other
cardinalities {2, 3, 4, 5, 7, 8} to check both the SIMD and fallback scalar
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
