costin commented on code in PR #16283:
URL: https://github.com/apache/lucene/pull/16283#discussion_r3473896566
##########
lucene/core/src/java25/org/apache/lucene/internal/vectorization/PanamaDocValuesRangeSupport.java:
##########
@@ -69,4 +69,60 @@ public void rangeIntoBitSet(
}
}
}
+
+ @Override
+ public void sortedNumericRangeIntoBitSet(
+ LongValues values,
+ int fromDoc,
+ int toDoc,
+ int cardinality,
+ long minValue,
+ long maxValue,
+ FixedBitSet bitSet,
+ int offset) {
+ final int vectorLen = LONG_SPECIES.length();
+ final int docsPerVector = vectorLen / cardinality;
Review Comment:
Improved the javadoc and added an assertion since the interface method is
public.
Fwiw, the code path already check cardinality > 1 in
LUcene()DocValuesProducer and fixedCardinality() returns either -1 (no fixed
cardinality) or ≥2 (since maxValueCount <= 1 bails out early).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
