gaobinlong commented on code in PR #16247:
URL: https://github.com/apache/lucene/pull/16247#discussion_r3433578710
##########
lucene/grouping/src/test/org/apache/lucene/search/grouping/BaseGroupSelectorTestCase.java:
##########
@@ -72,7 +73,6 @@ public void testSortByRelevance() throws IOException {
TopDocs td = searcher.search(filtered, 10);
assertScoreDocsEquals(topGroups.groups[i].scoreDocs(), td.scoreDocs);
if (i == 0) {
- assertEquals(td.scoreDocs[0].doc, topDoc.scoreDocs[0].doc);
Review Comment:
Similar to other PRs we did, we couldn't compare doc id because in
concurrent search mode, which doc with same highest score will be in the final
result is not guaranteed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]