gaobinlong commented on code in PR #16247:
URL: https://github.com/apache/lucene/pull/16247#discussion_r3426835378
##########
lucene/grouping/src/java/org/apache/lucene/search/grouping/AllGroupHeadsCollector.java:
##########
@@ -173,6 +173,7 @@ protected void doSetNextReader(LeafReaderContext context)
throws IOException {
@Override
public void setScorer(Scorable scorer) throws IOException {
this.scorer = scorer;
+ groupSelector.setScorer(scorer);
Review Comment:
In single-thread search, scorer is set in the first pass collector, see
https://github.com/apache/lucene/blob/0be06f9fe01782319f96e34f8e551ae5e76a0d1a/lucene/grouping/src/java/org/apache/lucene/search/grouping/FirstPassGroupingCollector.java#L177,
but in concurrent search mode, each collector has its own selector, so need to
set scorer separately, if not `values` in selector will be null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
