tlrx commented on PR #16086: URL: https://github.com/apache/lucene/pull/16086#issuecomment-4718700037
Thanks @mikemccand for the feedback. I opened #16264 to add additional merge abort checks before executing file integrity checksums (the point 2 that I suggested in https://github.com/apache/lucene/pull/16086#issuecomment-4497386359). Hopefully it's a less controversial change. It also threads `OneMerge` down to `MergeState` so that once it is merged I can follow up with the other proposed change: > > > Overall I think the simplest path is a checkIntegrity(OneMerge) overload that propagates the abort check down to checksumEntireFile, where it checks every ~1MB seek as Robert suggested. > > +1, that's a delightfully simple solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
