benwtrent commented on code in PR #16034:
URL: https://github.com/apache/lucene/pull/16034#discussion_r3202503261
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/AbstractHnswGraphSearcher.java:
##########
@@ -96,14 +96,78 @@ protected static void scoreEntryPoints(
assert scores != null && scores.length >= eps.length;
scorer.bulkScore(eps, scores, eps.length);
results.incVisitedCount(eps.length);
+ float[] siblingScores = null;
Review Comment:
`scoreEntryPoints` is about getting to the best approximate option in the
bottom layer. I don't think it adds too much work, but I wonder it is helping
at all, and I suspect it isn't, and thus shouldn't be done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
