aruggero commented on code in PR #16034:
URL: https://github.com/apache/lucene/pull/16034#discussion_r3202130043
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/AbstractHnswGraphSearcher.java:
##########
@@ -96,14 +96,78 @@ protected static void scoreEntryPoints(
assert scores != null && scores.length >= eps.length;
scorer.bulkScore(eps, scores, eps.length);
results.incVisitedCount(eps.length);
+ float[] siblingScores = null;
Review Comment:
Hi @benwtrent,
From what @alessandrobenedetti and I had seen, `scoreEntryPoints()` is done
only once (multiple times only with a seeded query in knn), since we have:
org.apache.lucene.util.hnsw.AbstractHnswGraphSearcher#search
`search()` calling `findBestEntryPoint()` + `searchLevel()`
org.apache.lucene.util.hnsw.HnswGraphSearcher#searchLevel
and `searchLevel()` (which calls `scoreEntryPoints()`) is called only on
level 0
It shouldn't add too much work here, right?
Moving this to the search-only part would break some assertions on visits
that we would need to manage otherwise...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
