iprithv commented on PR #15993: URL: https://github.com/apache/lucene/pull/15993#issuecomment-4360709523
> I am wondering if this information needs to stored as part of `DocValuesSkipper` as this should be single value per field per segment right? Also, this PR - #15737 might be related. Thanks for taking a look. Yes, `maxValueCount` is a single global value per field per segment. This PR stores it that way: it is part of the Lucene90 `DocValuesSkipperEntry` field metadata, alongside the existing global `minValue`, `maxValue`, `docCount`, and `maxDocId`. It is not stored per skip interval/block. I put it on `DocValuesSkipper` because this is where Lucene already exposes doc-values-derived segment-level metadata for fields that have a skip index. Putting it in `FieldInfo` would make it look like schema/static field metadata, but it is actually a computed per-segment doc values statistic and may be unavailable when no skipper is present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
