kaivalnp commented on code in PR #15784:
URL: https://github.com/apache/lucene/pull/15784#discussion_r2982919680
##########
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##########
@@ -46,24 +50,19 @@ abstract class AbstractVectorSimilarityQuery extends Query {
* the filter, and then falls back to exact search if results are incomplete.
*
* @param field a field that has been indexed as a vector field.
- * @param traversalSimilarity (lower) similarity score for graph traversal.
- * @param resultSimilarity (higher) similarity score for result collection.
+ * @param resultSimilarity similarity score for result collection.
+ * @param decay decay factor for graph traversal buffer.
* @param filter a filter applied before the vector search.
*/
- AbstractVectorSimilarityQuery(
- String field, float traversalSimilarity, float resultSimilarity, Query
filter) {
- if (traversalSimilarity > resultSimilarity) {
- throw new IllegalArgumentException("traversalSimilarity should be <=
resultSimilarity");
- }
+ AbstractVectorSimilarityQuery(String field, float resultSimilarity, float
decay, Query filter) {
Review Comment:
Yes, the concrete classes (`[Byte|Float]VectorSimilarityQuery`) have a
constructor with a default decay of `0.5`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
