kaivalnp commented on code in PR #15784:
URL: https://github.com/apache/lucene/pull/15784#discussion_r2982900589
##########
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##########
@@ -29,15 +29,19 @@
import org.apache.lucene.util.Bits;
/**
- * Search for all (approximate) vectors above a similarity threshold.
+ * Search for all (approximate) vectors above a similarity threshold using
{@link
+ * VectorSimilarityCollector}.
*
* @lucene.experimental
*/
abstract class AbstractVectorSimilarityQuery extends Query {
// TODO, switch to optionally use the new strategy
Review Comment:
This is related to filtering -- the new strategy is an ACORN-esque filtered
HNSW search (#14160).
Right now, the similarity-based vector search query [does not use
it](https://github.com/apache/lucene/blob/83e3f9ac24ac282ae353d0e0566f64640fe919a3/lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java#L38).
It sounds beneficial in general (only scores nodes matching the filter),
just that we haven't benchmarked it to enable by default (which should be
easier after https://github.com/mikemccand/luceneutil/pull/542).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
