kaivalnp commented on code in PR #15836:
URL: https://github.com/apache/lucene/pull/15836#discussion_r2974965047
##########
lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java:
##########
@@ -122,7 +122,17 @@ public ScorerSupplier scorerSupplier(LeafReaderContext
context) throws IOExcepti
// If there is no filter
if (filterWeight == null) {
- // Return exhaustive results
+ if (traversalSimilarity == Float.NEGATIVE_INFINITY && queryTimeout
== null) {
Review Comment:
Ah I see.. This function was meant to check whether approximate search
honors the timeout -- perhaps we can change `traversalSimilarity` and
`resultSiilarity` to `Math.nextUp(Float.NEGATIVE_INFINITY)` to ensure that
approximate search occurs here? (instead of fallback to exact)
Consequently, we can add a case in [this
function](https://github.com/apache/lucene/blob/2e3f36a5d58842050f12bca473b29d52b12fa1fb/lucene/core/src/test/org/apache/lucene/search/BaseVectorSimilarityQueryTestCase.java#L438)
that enforces that exact search is used, even without a restrictive filter,
when `traversalSimilarity == Float.NEGATIVE_INFINITY`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]