sgup432 commented on code in PR #15836: URL: https://github.com/apache/lucene/pull/15836#discussion_r2962336414
########## lucene/core/src/java/org/apache/lucene/search/AbstractVectorSimilarityQuery.java: ########## Review Comment: >Should we avoid approximate search in the filtered case too? Looking at the code, seems like we do handle it in some way? As we do approximate search first, then check `totalHits.relation()`, if it was incomplete we do fallback to exact search. About the other comment, seems like it needs more thought and worthy of a separate PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
