herley-shaori commented on PR #15824:
URL: https://github.com/apache/lucene/pull/15824#issuecomment-4068022099
> Can you please make clear which exact JVM version you are using while
seeing the regression? Mike's benchamrks are on Java 25 already (Lucene main).
>
> There were some issues with the MemorySegmentSessionImpl that were solved
in Java 24. I have the feeling that it might be a good idea to test with latest
LTS release of JVM. Java 21 works with mmap, but is already "outdated".
>
> Uwe
My environment:
- JDK: Eclipse Temurin 25.0.2+10 (LTS)
- macOS (Apple Silicon)
What I did: I read the analysis in #15820 (which reports the regression on
Amazon Corretto 21.0.8), explored the TrieReader/seekExact code path, and
attempted a fix based on the assumption that loading the trie on-heap would
avoid the mmap overhead. I did not independently reproduce or benchmark the
regression ourselves.
What I got wrong: As you, @rmuir, and @gf2121 pointed out:
- FST in 9.x was already off-heap (mmap) since LUCENE-9257, not
heap-resident
- ByteBuffersDataInput performs similar bounds checks, so the approach
doesn't address the root cause
- The real question is why Hotspot fails to elide checkValidStateRaw() in
this code path
On the JVM version question: The issue reporter uses Corretto 21.0.8. If
Panama MemorySegmentSessionImpl optimizations landed in Java 24+, that could
explain why Mike's Java 25 benchmarks show the trie as faster while the
reporter sees a regression on Java 21. It would be worth asking the reporter to
reproduce on Java 24 or 25 to confirm whether the issue is JVM-version-specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]