uschindler commented on PR #15824: URL: https://github.com/apache/lucene/pull/15824#issuecomment-4067823423
I think @gf2121 pointed it out in issue already: https://github.com/apache/lucene/issues/15820#issuecomment-4065638581 The problem is not on-heap vs off-hep. The problem here is also not the bounds check, it is obviouly a missing optimization in Panama that is required if the index is still open. With old MMapDirectoryy this was not done by the VM, risking to crash the VM when the file was closed. Normally the check should be elided by Hotspot, butr for some reason it does not happen here. I assume the problem is that there are so many segments open at same time and maybe the check cannot be cached? The bigger question here is: Why do we not see it for other loads of MememorySegmentIndexInput and only in this code path? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
