benwtrent commented on code in PR #15443:
URL: https://github.com/apache/lucene/pull/15443#discussion_r2549660310
##########
lucene/core/src/test/org/apache/lucene/internal/vectorization/TestVectorUtilSupport.java:
##########
@@ -39,7 +39,7 @@ public class TestVectorUtilSupport extends
BaseVectorizationTestCase {
public TestVectorUtilSupport(int size) {
this.size = size;
// scale the delta with the size
- this.delta = 1e-5 * size;
+ this.delta = 1e-4 * size;
Review Comment:
I don't think its a delta problem. I think its a magnitude problem. Could we
take into account the actual magnitude of the vectors, etc?
Something like:
```
float delta = Math.max(eps, eps * Math.max(result1, result2));
assertEquals(result1, result2, Math.max(delta, eps));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
