kaivalnp commented on code in PR #15341:
URL: https://github.com/apache/lucene/pull/15341#discussion_r2543371182
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsWriter.java:
##########
@@ -153,10 +153,19 @@ public long ramBytesUsed() {
return total;
}
+ private static long alignOutput(IndexOutput output, VectorEncoding encoding)
throws IOException {
+ return output.alignFilePointer(
Review Comment:
The compound file seems to [align _all_
files](https://github.com/apache/lucene/blob/dd70ed5801e370bfc05ccd3f3f96415fb93c5cc8/lucene/core/src/java/org/apache/lucene/codecs/lucene90/Lucene90CompoundFormat.java#L124)
to 8 bytes (`Long.BYTES`) inside the "blob" -- which works because all other
`alignFilePointer` calls I see are factors of 8 (I only see 4 byte alignment,
using `Float.BYTES`)
> we may/should make this configurable in CFS files, too
Would this involve aligning _all_ files to 64 bytes instead? (because we do
not retain the intended alignment in the index, so we'd have to pick the LCM of
all occurrences of `alignFilePointer` in the codebase?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
