kaivalnp commented on code in PR #15341:
URL: https://github.com/apache/lucene/pull/15341#discussion_r2535578494
##########
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/VectorScorerBenchmark.java:
##########
@@ -62,57 +66,140 @@
value = 3,
jvmArgsAppend = {"-Xmx2g", "-Xms2g", "-XX:+AlwaysPreTouch"})
public class VectorScorerBenchmark {
+ private static final float EPSILON = 1e-4f;
@Param({"1", "128", "207", "256", "300", "512", "702", "1024"})
public int size;
+ @Param({"0", "1", "2", "4", "6", "8", "16", "20", "32", "50", "64", "100",
"128", "255", "256"})
Review Comment:
Q: I added a bunch of values during testing, should we reduce while
committing? (say 0, 1, 4, 64)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
