salvatorecampagna commented on code in PR #15378:
URL: https://github.com/apache/lucene/pull/15378#discussion_r2482423482


##########
lucene/CHANGES.txt:
##########
@@ -69,6 +69,12 @@ Improvements
 
 * GITHUB#15124: Use RamUsageEstimator to calculate size for non-accountable 
queries. (Sagar Upadhyaya)
 
+* GITHUB#14515: IndexWriter.forceMergeDeletes() now returns 
MergePolicy.MergeObserver,

Review Comment:
   I see the PR is targeting main (milestone 11.0.0). According to 
`CONTRIBUTING.md`
   
   ```
   You should open a pull request against the main branch. Committers will 
backport it to the maintenance branches once the change is merged into main.
   ```
   
   Should I keep the `CHANGES.txt` entry in `11.0.0` for now, and then it gets 
moved to `10.4` in a backport PR if needed? Or should I change it to `10.4.0` 
now and update the milestone as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to