salvatorecampagna commented on code in PR #15378:
URL: https://github.com/apache/lucene/pull/15378#discussion_r2482390507
##########
lucene/core/src/test/org/apache/lucene/index/TestIndexWriterMerging.java:
##########
@@ -333,6 +337,330 @@ public synchronized void merge(MergeSource mergeSource,
MergeTrigger trigger)
public void close() {}
}
Review Comment:
Thank you! I'm a fan of good tests, they're as important as the code itself,
documenting behavior and preventing regressions.
This is my first Lucene contribution, so I really appreciate your detailed
feedback on the API design. The suggestions made the API much cleaner and safer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
