RamakrishnaChilaka commented on PR #15358: URL: https://github.com/apache/lucene/pull/15358#issuecomment-3457835304
Understood @rmuir, makes sense. I agree that mixing both changes (integer encoding vs dataoutput changes) makes the numbers hard to interpret and that changes to `DataOutput` require extra caution since they impact multiple components. As next steps * I will rework this PR, to focus purely on optimising the integer encoding logic within `ForUtil` (keeping the existing `DataOutput` interface unchanged) * If still valuable in terms of performance, I can follow up seperately with a small PR that explores a dedicated bulk write path in `DataOutput`, including isolated benchmarks to measure its standalone impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
