RamakrishnaChilaka commented on PR #15358: URL: https://github.com/apache/lucene/pull/15358#issuecomment-3457749454
thanks for reviewing the PR, @rmuir! The change to `DataOutput` was needed to introduce a bulk integer write path via `writeInts(int[] values, int len))`. This allows `ForUtil` to write packed integers in a single call rather than looping with multiple `writeInt()` calls, reducing call overhead. I considered keeping the logic internal to `ForUtil`, but since most packed data writing eventually goes through `DataOutput`, exposing a bulk write method there allows other codecs or utilities to reuse this optimization when possible. If preferred, I can refactor it so that `ForUtil` handles the batched writes internally (without modifying `DataOutput`), if the output is of type [OutputStreamIndexOutput.java](https://github.com/apache/lucene/pull/15358/files#diff-6bbd8be55259ac49e12d8e366f3115a2f29607c486c2b4503023e1daf9a1b1d8) (other output types can be added too) Let me know which approach you’d prefer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
