msokolov commented on code in PR #15357:
URL: https://github.com/apache/lucene/pull/15357#discussion_r2461065977
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene104/Lucene104ScalarQuantizedVectorsWriter.java:
##########
@@ -72,12 +76,8 @@ public class Lucene104ScalarQuantizedVectorsWriter extends
FlatVectorsWriter {
private final Lucene104ScalarQuantizedVectorScorer vectorsScorer;
private boolean finished;
- /**
- * Sole constructor
- *
- * @param vectorsScorer the scorer to use for scoring vectors
- */
- protected Lucene104ScalarQuantizedVectorsWriter(
+ /** Sole constructor */
+ public Lucene104ScalarQuantizedVectorsWriter(
Review Comment:
got it thanks. Would love to see the `bfloat16` support contributed here at
some point!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
